[bisq-network/bisq] Switch to more accurate fee estimation endpoint (#4235)
notifications at github.com
Wed May 6 19:17:16 UTC 2020
> Really great work here, @cd2357. Thanks!
Thanks, glad I could help :)
> Note that there is an opportunity here for one or more follow-on PRs as well.
> The first is to eliminate the `maxBlocks` field from `BitcoinFeeRateProvider`. You'll see my comments to this effect. Rolling this out means changing the startup scripts and communicating effectively about the change to @bisq-network/pricenode-operators. It would be great if you want to do this, @cd2357.
If I understood that correctly, this PR should cover it: https://github.com/bisq-network/bisq/pull/4240. I assume there are startup or service scripts which are not committed, which the operators have on their systems. If so, that's one thing they'll have to manually adjust (already described that in PR comment for their reference).
As to communicating it them, I'm not sure who whey are so I can tag them, nor can I use the @bisq-network/pricenode-operators tag you used @cbeams (it doesn't resolve for me, it just stay as text). So I'd leave the comm part to someone else, perhaps @wiz ?
> The second is implementing the configurability that @wiz mentioned in the comments on this PR.
Already started with that, a PR is coming soon.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github