[bisq-network/bisq] Reason for payment is now list of fake reasons instead of random string ID to obfuscate fact its from the Bisq (#4249)

[Petr Hejna]

Solves https://github.com/bisq-network/bisq/issues/2869

![image](https://user-images.githubusercontent.com/383295/81486787-994d2000-9257-11ea-85d3-33f5f0da9c68.png)

----

For now, the list of reasons is very limited, and I need to find some more (like hundreds more) reasons. But from the code perspective it's working.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4249

-- Commit Summary --

  * Reason for payment is now list of fake reasons instead of random string ID to obfuscate fact its from the Bisq

-- File Changes --

    A common/src/main/java/bisq/common/util/ReasonsForPayment.java (30)
    A common/src/test/java/bisq/common/util/ReasonsForPaymentTests.java (17)
    M core/src/main/java/bisq/core/offer/Offer.java (5)
    M core/src/main/java/bisq/core/trade/Trade.java (5)
    M core/src/main/resources/i18n/displayStrings.properties (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4249.patch
https://github.com/bisq-network/bisq/pull/4249.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4249
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200509/d78839fa/attachment.html>