[bisq-network/bisq] OfferBook: Show min-max range for amount and volume (#4225)
Petr Hejna
notifications at github.com
Sun May 10 09:18:18 UTC 2020
@petrhejna commented on this pull request.
> @@ -528,12 +525,25 @@ public void updateItem(final OfferListItem offerListItem, boolean empty) {
setGraphic(null);
}
}
+
+ /**
+ * Renders cell content, if it has a single value or a range.
+ * Should not be called for empty cells
Is this comment really needed? Maybe naming `renderCellContent()` is enough as it is private method in very specific context.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4225#pullrequestreview-408725159
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/b95b187e/attachment.html>
More information about the bisq-github
mailing list