[bisq-network/bisq] UI: In OfferBook, show tooltip on data point hover (#4228)

Petr Hejna notifications at github.com
Sun May 10 09:40:22 UTC 2020


@petrhejna commented on this pull request.



> @@ -421,9 +427,47 @@ private void updateChartData() {
 
         seriesBuy.getData().addAll(model.getBuyData());
         seriesSell.getData().addAll(model.getSellData());
+
+        // Before adding the points to the chart, set a custom node used for showing a label on hover

Instead of a comment, I would prefer the nicely named method. Comments tend to age and becoming inconsistent with the code. Best documentation is the code itself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4228#pullrequestreview-408726908
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/e82425e5/attachment.html>


More information about the bisq-github mailing list