[bisq-network/bisq] UI: In OfferBook, show tooltip on data point hover (#4228)
Petr Hejna
notifications at github.com
Sun May 10 09:51:44 UTC 2020
@petrhejna commented on this pull request.
> areaChart.getData().addAll(List.of(seriesBuy, seriesSell));
}
+ /**
+ * A node which displays a label on hover, but is otherwise empty
+ *
+ * Based on https://gist.github.com/jewelsea/1422628
+ */
+ protected class HoveredLabelNode extends StackPane {
I would move this Node to the separate file and pass data via constructor (the price ->`xAxis.getTickLabelFormatter().toString(price)`.
This file is quite long already and this is separable responsibility.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4228#pullrequestreview-408727812
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/177b2869/attachment.html>
More information about the bisq-github
mailing list