[bisq-network/bisq] Bugfixes related to switch statements (#4250)

dmos62 notifications at github.com
Sun May 10 13:04:30 UTC 2020


This is a second go at https://github.com/bisq-network/bisq/pull/4212, which was reverted. The previous PR was fixing some problems with switch statements and a typo where a short-circuit boolean operator was used without need. This PR is the same as the last one, but the semantic/cosmetic changes (why the original PR was reverted) are removed and it also implements a suggestion by @ManfredKarrer to add a (forgotten) check.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4250

-- Commit Summary --

  * Typo short-circuit boolean operator
  * Fix forgotten break in switch statement #1
  * Fix forgotten break in switch statement #2
  * Check if these *_MIN_AMOUNTs don't exceed 200k BSQ

-- File Changes --

    M core/src/main/java/bisq/core/dao/governance/proposal/param/ChangeParamValidator.java (4)
    M core/src/main/java/bisq/core/dao/node/parser/TxOutputParser.java (1)
    M p2p/src/main/java/bisq/network/p2p/network/Connection.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4250.patch
https://github.com/bisq-network/bisq/pull/4250.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4250
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/4fc9dc6d/attachment.html>


More information about the bisq-github mailing list