[bisq-network/bisq] Update DAO doc to hint running seed as full node (#4248)

James Cox notifications at github.com
Mon May 11 04:30:12 UTC 2020


@jmacxx requested changes on this pull request.

Adding some text specifying seed node = full, alice/bob being (potentially) lite nodes is useful; in fact it helped me fix a mis-configuration in my own regtest setup.  Duplicating the command line parameters is distracting though.

> @@ -113,6 +113,14 @@ Lite node mode:
 _Don't forget to use different rpcBlockNotificationPorts for different full node instances, otherwise only one node will receive the new block event forwarded to that port._
 
 
+In default setup you need to run seed node as **full node**:
+`./bisq-seednode --daoActivated=true --genesisBlockHeight=111 --genesisTxId=30af0050040befd8af25068cc697e418e09c2d8ebd8d411d2240591b9ec203cf --baseCurrencyNetwork=BTC_REGTEST --useDevPrivilegeKeys=true --useLocalhostForP2P=true --nodePort=2002 --appName=bisq-BTC_REGTEST_Seed_2002 --fullDaoNode=true --rpcUser=YOUR_USER_NAME --rpcPassword=YOUR_PW --rpcPort=18443 --rpcBlockNotificationPort=5120`

Your line about seed node being full node is good.  Not necessary to repeat the command line parameters here, since it has already been specified in this section of the document.  

> @@ -113,6 +113,14 @@ Lite node mode:
 _Don't forget to use different rpcBlockNotificationPorts for different full node instances, otherwise only one node will receive the new block event forwarded to that port._
 
 
+In default setup you need to run seed node as **full node**:
+`./bisq-seednode --daoActivated=true --genesisBlockHeight=111 --genesisTxId=30af0050040befd8af25068cc697e418e09c2d8ebd8d411d2240591b9ec203cf --baseCurrencyNetwork=BTC_REGTEST --useDevPrivilegeKeys=true --useLocalhostForP2P=true --nodePort=2002 --appName=bisq-BTC_REGTEST_Seed_2002 --fullDaoNode=true --rpcUser=YOUR_USER_NAME --rpcPassword=YOUR_PW --rpcPort=18443 --rpcBlockNotificationPort=5120`
+
+Then both Alice and Bob and the arbitrator as **lite nodes**:
+* `./bisq-desktop --daoActivated=true --genesisBlockHeight=111 --genesisTxId=30af0050040befd8af25068cc697e418e09c2d8ebd8d411d2240591b9ec203cf --baseCurrencyNetwork=BTC_REGTEST --useDevPrivilegeKeys=true --useLocalhostForP2P=true --nodePort=4444 --appName=bisq-BTC_REGTEST_arbitrator`

Your line about Alice and Bob able to be lite node is good.  Not necessary to repeat the command line parameters here, since it has already been specified in this section of the document.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4248#pullrequestreview-408850988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/91eabde0/attachment.html>


More information about the bisq-github mailing list