[bisq-network/bisq] Extend FeeRateService to support multiple API endpoints (#4247)

cd2357 notifications at github.com
Mon May 11 06:51:28 UTC 2020


FYI for reviewers: I realise its a relatively big change, so here's a short "changelog" to help with the review:

* `build.gradle`
  * added test dependencies for Jupiter
* `README.md`
  * added short description of how the endpoints can be configured
* `FeeRateService`
  * before: get fee rate from provider
  * now
     * get fee rates from all available providers + calculate average
     * fallback to `BitcoinFeeRateProvider.MIN_FEE_RATE` if providers are (temporarily) unreachable
* `BitcoinFeeRateProvider`
  * convert to abstract class
  * define five subclasses of it, each with its own endpoint API, which represent the diffeent providers
  * annotate subclasses so that they are only instantiated when endpoint URL is defined
  * first subclass defaults to mempool.space in case nothing else is defined (or config is corrupted)
* `application.properties`
  * extend file with 5 properties (API endpoints for supported fee providers)
* the rest are tests

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4247#issuecomment-626507356
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200510/9b071f4a/attachment.html>


More information about the bisq-github mailing list