[bisq-network/bisq] Add memo field to withdrawal transaction (#4229)
sqrrm
notifications at github.com
Tue May 12 17:10:15 UTC 2020
@sqrrm commented on this pull request.
Tested it. The popup is not following dark mode scheme I think.
![image](https://user-images.githubusercontent.com/23560607/81724101-1bba2780-9484-11ea-8475-9c9b8e552fe6.png)
> @@ -164,7 +163,8 @@ private WithdrawalView(BtcWalletService walletService,
@Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,
Preferences preferences,
BtcAddressValidator btcAddressValidator,
- WalletPasswordWindow walletPasswordWindow) {
+ WalletPasswordWindow walletPasswordWindow
+ ) {
This is not customary. Not sure if it's in the style guide, but better keep it in line with other code and not line break before the parenthesis.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4229#pullrequestreview-410164049
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200512/b439f459/attachment-0001.html>
More information about the bisq-github
mailing list