[bisq-network/bisq] Display correct trade and tx fees in CSV export (#4256)

[James Cox]

When exporting trade history to CSV, users would expect to see their own transaction and trade fees listed.  Maker fees are stored on the Offer, Taker fees are stored on the Trade object.
The code was not properly checking whether the user was the Offer Maker or Taker, and as such the report was always displaying the Taker information for Tx and Trade fee.  Therefore any trades where the user was Maker showed the wrong fees.

The column title `Maker Fee` is incorrect and misleading since the user doing the export is not necessarily the Maker.  We rename this column to `Trade Fee` to indicate that it is the fee the user paid for trading, regardless of Maker/Taker status.

Fixes #4207 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4256

-- Commit Summary --

  * Display correct trade and tx fees in CSV export

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.fxml (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java (14)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4256.patch
https://github.com/bisq-network/bisq/pull/4256.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4256
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200512/5e0aa068/attachment.html>