[bisq-network/bisq] Display "Payment Method" column in Open Offers view (#4193)

James Cox notifications at github.com
Thu May 14 15:09:49 UTC 2020


@jmacxx commented on this pull request.



> @@ -118,6 +121,23 @@ String getMarketLabel(OpenOfferListItem item) {
         return CurrencyUtil.getCurrencyPair(item.getOffer().getCurrencyCode());
     }
 
+    String getPaymentMethod(OpenOfferListItem item) {
+        String result = "";
+        if (item != null) {
+            Offer offer = item.getOffer();
+            checkNotNull(offer);
+            checkNotNull(offer.getPaymentMethod());
+            String method = Res.get(offer.getPaymentMethod().getId() + "_SHORT");

This method is copied directly from PendingTradesViewModel.java (line 273).  I presume since the code is already working, no need to change it.  I'm open to suggestions of changing both though, if you have strong worries about it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4193#discussion_r425212133
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200514/65add37d/attachment-0001.html>


More information about the bisq-github mailing list