[bisq-network/bisq] Prevent transient negative missingCoin amount sent to QRCode display (#4258)

[James Cox]

In bisq-network/bisq/pull/4223 a fix was made to the QRCode display of amount needed to fund an offer.  This accidentally introduced a bug whereby if the user overpaid the funding, then the QRCode would throw an error `Coin must be positive`.  This is due to a race condition in OfferDataModel which was setting a property first to a negative amount before checking if it was negative and if so then setting it to zero.  The fix here is to check for negative before setting the property so that any listeners do not get an event (negative) followed by another event (zero).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4258

-- Commit Summary --

  * Prevent transient negative missingCoin amount sent to QRCode display

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/OfferDataModel.java (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4258.patch
https://github.com/bisq-network/bisq/pull/4258.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200514/4fd9ce3c/attachment.html>