[bisq-network/bisq] Final step of trade (withdraw BTC to external wallet) fails (#4205)

[James Cox]

### Steps to reproduce, example 1

- Alice: Create two trades with Bob as either maker/taker, and take them through to step 4.
- Alice: At step 4, withdraw one of the trades to external wallet.
- Alice: At step 4, attempt to withdraw the other trade to external wallet.  It will fail with this error.

### Steps to reproduce, example 2

- Alice: Create one trade with Bob as either maker/taker, and take it to step 4.
- Alice: Shut down bisq application, and restart.
- Alice: At step 4, attempt to withdraw the trade funds to external wallet.  It will fail with this error.

In both scenarios the following warning will be observed in the log, some point earlier:

`WARN  bisq.core.trade.TradeManager: We found an outdated addressEntry for trade [offerid]: entry=AddressEntry{offerId='[offerid]', context=TRADE_PAYOUT, address=[address]}`

That log message represents a point in the code where the reserved address is (prematurely) released from the offer back to the bisq wallet.

Then you get the Missing x.xxxx BTC / Insufficient Funds error:

![image](https://user-images.githubusercontent.com/47253594/82081050-49cd8080-96ab-11ea-9eb4-2de7c6f7cbcb.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4205#issuecomment-629398073
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200515/4e380528/attachment.html>