[bisq-network/bisq] Fix trade withdraw to external wallet step 4 (#4260)

[James Cox]

The routine `cleanUpAddressEntries` in TradeManager was prematurely releasing funds associated with trades when they reach the last step of the process (Step 4, Withdraw to External Wallet). 

Usually, with a single trade active this would not be an issue because `cleanUpAddressEntries` is called after the withdrawal, but if you have more than one trade at Step 4 then the first withdrawal would go though, but all the others would fail with an error box "Missing x.xxx BTC" (the trade proceeds or deposit amount).  Alternatively, if you restart the bisq app with a
trade in Step 4, the same cleanup will occur and the attempt to withdraw to external wallet will fail.

The change here considers any trade held by the TradeManager to be in use and therefore will not have their associated address entries freed up.  After Step 4 has passed, the trade is no
longer held by the TradeManager, and so `cleanUpAddressEntries` will at that point free up the address.

Fixes #4205
Fixes #3592
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4260

-- Commit Summary --

  * Fix trade withdraw to external wallet step 4

-- File Changes --

    M core/src/main/java/bisq/core/trade/TradeManager.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4260.patch
https://github.com/bisq-network/bisq/pull/4260.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4260
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200515/0d6441d5/attachment.html>