[bisq-network/bisq] Add memo field to withdrawal transaction (#4229)

Petr Hejna notifications at github.com
Fri May 15 21:26:46 UTC 2020


@petrhejna commented on this pull request.



> @@ -164,7 +163,8 @@ private WithdrawalView(BtcWalletService walletService,
                            @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,
                            Preferences preferences,
                            BtcAddressValidator btcAddressValidator,
-                           WalletPasswordWindow walletPasswordWindow) {
+                           WalletPasswordWindow walletPasswordWindow
+    ) {

:+1: this looks like some forgotten change after reverting my previous changes.

Maybe question/suggestion - is there any good automated style check (ideally with fixer) to solve issues like this to save some time? I am not really experienced in Java ecosystem, but I believe there is something like https://eslint.org/ but for Java.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4229#discussion_r426054664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200515/a6cbd5ec/attachment.html>


More information about the bisq-github mailing list