[bisq-network/bisq] [WIP] Create order using the same tx fee specified at funding (#4266)

[James Cox]

This fixes an issue whereby updates from the fee API were causing Insufficient Funds exception.  Since the wallet is funded with a specific amount (deposit+trade fee+txFee), that same amount has
to be used when the user confirms offer creation ([which could be some time later](https://github.com/bisq-network/bisq/issues/4227#issuecomment-629521456)).

Fixes #4227

Desktop Bisq `createAndGetOffer`needs to pass a fee value to `CreateOfferService` but `CoreApi::placeOffer` does not pass one, so had pass from there a dummy fee of Coin.ZERO which would equate to existing functionaliy, i.e. get current appropriate fee.
@ghubstan and @bisq-network/bisq-devs , requesting your input here.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4266

-- Commit Summary --

  * Create order using the same tx fee specified at funding

-- File Changes --

    M core/src/main/java/bisq/core/grpc/CoreApi.java (2)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4266.patch
https://github.com/bisq-network/bisq/pull/4266.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4266
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200517/8ccede2e/attachment-0001.html>