[bisq-network/bisq] Add rpc wallet protection method tests (#4243)

Chris Beams notifications at github.com
Mon May 18 12:30:34 UTC 2020


@cbeams requested changes on this pull request.

NACK. I've just merged #4214, and attempted to merge this as well, but there are a number of test failures. One fragile one is exact string matching on version (it's 1.3.2 in the tests but 1.3.4 on master right now). There are some other failures as well that weren't obvious to me at a glance.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4243#pullrequestreview-413546509
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200518/ff7211c8/attachment.html>


More information about the bisq-github mailing list