[bisq-network/projects] Introduce interface between Bisq and BitcoinJ (#30)

Oscar Guindzberg notifications at github.com
Sat May 23 22:56:31 UTC 2020


- I think this proposal is independent of https://github.com/bisq-network/proposals/issues/226. They don't compete with each other because they attack different problems.
- If both proposals are accepted I suggest not to code both projects in parallel because that would lead to merging hell. They could be implemented one after the other. If both proposals are accepted I suggest merging https://github.com/bisq-network/bisq/pull/4270 as a starting point, which is already coded and only requires peer review.
- I did a research of bitcoinj alternatives back in Dec 2018 and found no good alternative (https://github.com/bisq-network/bisq/issues/1062#issuecomment-446755367). As of today I think there are 2 alternatives to bitcoinj that might make sense for bisq: a) bitcoin core and use its RPC interface or b) Electrum client for java (does not exist yet, but could be implemented). Every alternative has its pro and cons. 
- Alternatives to bitcoinj might work very differently and would be difficult to abstract things without knowing the interfaces of the other libraries.  
- This is a personal taste comment: bitcoinj usage in bisq could be subject to refactors and other code improvements, but I prefer to create an abstraction of a library once I am already implementing the usage of an alternative library. You guys know the bisq source code better than me, so this comment might not make sense for bisq.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/projects/issues/30#issuecomment-633150950
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200523/d4ef2b70/attachment.html>


More information about the bisq-github mailing list