[bisq-network/bisq] [WIP] Add list to filter to set btc fee receiver addresses (#4150)

Steven Barclay notifications at github.com
Thu May 28 09:14:41 UTC 2020


I created a patch (on top of 1b86a7d3) breaking up the above method into 3 separate methods to make it a bit more testable, by avoiding the RNG nondeterminism. I also added some unit tests and fixed a slight issue with the above that an exception is thrown if all the recipient address+weight pairs are unparseable, instead of just some of them.

Feel free not to use it or to make further changes. I tested the patch on regtest and it seems to work with the weighted addresses. I'm also fairly sure the above would have worked as well.

It seems that my earlier confusion about the filter not being successfully broadcast was due to `FilterManager` exposing two separate `Filter` properties: `UserPayload.developersFilter` (stored locally, shown in the filter view and broadcast when adding a new filter) and `FilterManager.filterProperty` (loaded by each peer from the network and used for the actual filtering). Adding a filter on one node (say the mediator) did successfully apply it to the receiver address selection on the other nodes upon further testing, so I'm fairly sure there's no problem.

[Add_weights_to_fee_receiver_addresses.patch.txt](https://github.com/bisq-network/bisq/files/4694479/Add_weights_to_fee_receiver_addresses.patch.txt)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4150#issuecomment-635221494
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200528/c19ba95a/attachment.html>


More information about the bisq-github mailing list