[bisq-network/bisq] Allow user-defined block explorers (#4733)
chimp1984
notifications at github.com
Sun Nov 1 01:07:50 CET 2020
@chimp1984 approved this pull request.
utACK
Beside 2 nits... See comments
> @@ -937,6 +906,34 @@ private void activateDisplayPreferences() {
resetDontShowAgainButton.setOnAction(e -> preferences.resetDontShowAgain());
+ editCustomBtcExplorer.setOnAction(e -> {
+ EditCustomExplorerWindow urlWindow = new EditCustomExplorerWindow("BTC",
+ preferences.getBlockChainExplorer(), preferences.getBlockChainExplorers());
+ urlWindow
+ .actionButtonText("Save")
I think you forgot here to use a resource string. I guess its: `Res.get("shared.save")`
> + urlWindow
+ .actionButtonText("Save")
+ .onAction(() -> {
+ preferences.setBlockChainExplorer(urlWindow.getEditedBlockChainExplorer());
+ btcExplorerTextField.setText(preferences.getBlockChainExplorer().name);
+ })
+ .closeButtonText(Res.get("shared.cancel"))
+ .onClose(urlWindow::hide)
+ .show();
+ });
+
+ editCustomBsqExplorer.setOnAction(e -> {
+ EditCustomExplorerWindow urlWindow = new EditCustomExplorerWindow("BSQ",
+ preferences.getBsqBlockChainExplorer(), preferences.getBsqBlockChainExplorers());
+ urlWindow
+ .actionButtonText("Save")
I think you forgot here to use a resource string. I guess its: Res.get("shared.save")
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4733#pullrequestreview-521181295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201031/0bcb9ca5/attachment.html>
More information about the bisq-github
mailing list