[bisq-network/bisq] Allow user-defined block explorers (#4733)
Christoph Atteneder
notifications at github.com
Mon Nov 2 10:52:48 CET 2020
@ripcurlx requested changes on this pull request.
NACK
Code looks fine, but please change the style of the `>>` button to match our general button style.
> + Button button = new Button(">>");
+ button.setOnAction(e -> {
+ BlockChainExplorer blockChainExplorer = listView.getSelectionModel().getSelectedItem();
+ if (blockChainExplorer != null) {
+ nameInputTextField.setText(blockChainExplorer.name);
+ txUrlInputTextField.setText(blockChainExplorer.txUrl);
+ addressUrlInputTextField.setText(blockChainExplorer.addressUrl);
+ }
+ });
Please use our AutoTooltipButton or JFXButton to match the design of all other buttons.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4733#pullrequestreview-521476524
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201102/ea5c4f3f/attachment.html>
More information about the bisq-github
mailing list