[bisq-network/bisq] [WIP] Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...] (#4731)

[sqrrm]

@sqrrm approved this pull request.

utACK

I think this is ready to merge once [WIP] is removed

> @@ -164,14 +164,13 @@ public String getMarketDescription(Trade trade) {
     }
 
     public String getPaymentMethodNameWithCountryCode(Trade trade) {
-        String paymentMethodDescription = "";
-        if (trade != null) {
-            Offer offer = trade.getOffer();
-            checkNotNull(offer);
-            checkNotNull(offer.getPaymentMethod());
-            paymentMethodDescription = offer.getPaymentMethodNameWithCountryCode();
-        }
-        return paymentMethodDescription;
+        if (trade == null)
+            return "";
+
+        Offer offer = trade.getOffer();

This is not required, but I do like the notation
`Offer offer = checkNotNull(trade.getOffer());`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4731#pullrequestreview-521584653
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201102/c81d794d/attachment.html>