[bisq-network/bisq] Clean up mailbox messages for closed trades (#4746)

[chimp1984]

We got growing pending mailbox messages since 1.4.2. (about 2000 now, normal is about 500). With the trade protocol refactoring a cleanup for mailbox messages has been missed.

Steps to reproduce issue:
Start a trade and let peer go offline. When Seller confirms receipt he sends a msg to buyer, as he is offline its a mailbox msg. Seller moves funds to his wallet and his trade is closed. Buyer goes online and closes his trade as well. He sends back a AckMessage that he received the trade message but as sellers trade is closed that ackMsg is not being processed (done in tradeProtocol class which is not initialized for closed trades).

Solution:
We iterate closed and failed trades and look up if there are some pending mailbox messages and if we find any we remove them from the network. 
It can be that there are failure scenarios where mailbox messages did not got removed as well. This should fix those cases as well.

 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4746

-- Commit Summary --

  * Clean up mailbox messages for closed trades

-- File Changes --

    M core/src/main/java/bisq/core/app/DomainInitialisation.java (10)
    A core/src/main/java/bisq/core/trade/closed/CleanupMailboxMessages.java (129)
    M core/src/main/java/bisq/core/trade/closed/ClosedTradableManager.java (10)
    M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4746.patch
https://github.com/bisq-network/bisq/pull/4746.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4746
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201103/14e9927e/attachment.html>