[bisq-network/bisq] Remove outliers when calculating BSQ rate (#4706)

[Chris Beams]

> Fixed with #4745

Thanks, @chimp1984. As I just mentioned at https://github.com/bisq-network/bisq/pull/4745#issuecomment-721678385, I've tested this locally, and I can see that the fix works.

However, there is still a problem that goes back to my original comment on this PR above at https://github.com/bisq-network/bisq/pull/4706#issuecomment-721142743.

The following screenshots are of two different Bisq instances running against latest master at 63cae1ceb1a83641f8c738e17e01fbf552958dec, i.e. with PR #4745 merged. Notice the discrepancy between the average trade price values:

This is master running against an fresh data directory:

<img width="1312" alt="image" src="https://user-images.githubusercontent.com/301810/98106918-11f50800-1e9a-11eb-80a2-96486c338271.png">

And this is master running against my actual data directory, i.e. my personal Bisq client as I usually run it:

<img width="1312" alt="image" src="https://user-images.githubusercontent.com/301810/98107492-e1619e00-1e9a-11eb-8690-d9e6e76e726a.png">

The former appears to have the outliers removed as intended, while the latter does not. The latter displays roughly the same values as it did against v1.4.2.

Note that DAO synchronization is complete on both of the above clients.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4706#issuecomment-721682940
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201104/5a257ffa/attachment-0001.html>