[bisq-network/bisq] Use vsize (#4755)

Oscar Guindzberg notifications at github.com
Thu Nov 5 23:40:02 CET 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

This is a follow up of https://github.com/bisq-network/bisq/pull/4710
Since segwit was implemented we use "bitcoin transaction virtual size" instead of "bitcoin transaction size" in the code.
I did not want to do all the renaming of methods and variable names in https://github.com/bisq-network/bisq/pull/4710 to reduce merging hell.
So, I am doing it now.
Don't get overwhelmed by the number of changes... this is just a renaming PR.

Please, merge https://github.com/bisq-network/bisq/pull/4754 before merging this PR.



You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4755

-- Commit Summary --

  * Complete Use segwit tx sizes
  * Rename "tx size" to "tx vsize"

-- File Changes --

    M common/src/main/java/bisq/common/config/BaseCurrencyNetwork.java (2)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (140)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (62)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (8)
    M core/src/main/java/bisq/core/dao/DaoFacade.java (18)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (6)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (6)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (6)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (12)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (8)
    M core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java (35)
    M core/src/main/java/bisq/core/provider/fee/FeeService.java (26)
    M core/src/main/java/bisq/core/user/Preferences.java (12)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (6)
    M core/src/main/java/bisq/core/util/coin/CoinUtil.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (28)
    M core/src/test/java/bisq/core/btc/TxFeeEstimationServiceTest.java (84)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (22)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/assetfee/AssetFeeView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java (12)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java (8)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (14)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (12)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (14)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (62)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (12)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java (10)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (30)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (16)
    M pricenode/src/main/java/bisq/price/mining/FeeRateProvider.java (2)
    M pricenode/src/main/java/bisq/price/mining/providers/MempoolFeeRateProvider.java (2)
    M proto/src/main/proto/pb.proto (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4755.patch
https://github.com/bisq-network/bisq/pull/4755.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4755
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201105/fbfa7fec/attachment.html>


More information about the bisq-github mailing list