[bisq-network/bisq] Apply format to trading charts axis Y values (#4761)
deusmax
notifications at github.com
Sat Nov 7 11:14:41 CET 2020
<!--
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
This PR completes the improvements to trading charts introduced in PRs #4715 and #4740, by formatting the Y-axis values as:
- Fiat: Apply separator format to numbers
- Crypto: remove some (not all) trailing zeroes from fractional part
Here is the result for the EUR chart, similar for other fiat:
![Bisq-charts-Yaxis_EUR-day-2020-11-04](https://user-images.githubusercontent.com/142019/98438133-d2742900-20f0-11eb-8963-fe14c491cf07.png)
Below are before and after for various cryptos:
XMR before:
![Bisq-charts-Yaxis_XMR0-day-2020-11-05](https://user-images.githubusercontent.com/142019/98438212-6c3bd600-20f1-11eb-8579-dd9b6e8f8f36.png)
XMR after:
![Bisq-charts-Yaxis_XMR-day-2020-11-05](https://user-images.githubusercontent.com/142019/98438228-82e22d00-20f1-11eb-8c71-b359f5a3ec0e.png)
BSQ before:
![Bisq-charts-Yaxis_BSQ0-day-2020-11-05](https://user-images.githubusercontent.com/142019/98438299-eec49580-20f1-11eb-8caa-ae23a3b7763e.png)
BSQ after
![Bisq-charts-Yaxis_BSQ-day-2020-11-05](https://user-images.githubusercontent.com/142019/98438303-fa17c100-20f1-11eb-9c62-d27bcb399e9e.png)
ETH before:
![Bisq-charts-Yaxis_ETH0-week-2020-11-05](https://user-images.githubusercontent.com/142019/98438333-27fd0580-20f2-11eb-873e-86b4d72f2174.png)
ETH after:
![Bisq-charts-Yaxis_ETH-week-2020-11-05](https://user-images.githubusercontent.com/142019/98438353-3a773f00-20f2-11eb-80d9-9af018e1e2cd.png)
What do you think ?
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4761
-- Commit Summary --
* Format fiat currency tick mark label on Y-axis.
* Remove trailing zeroes from crypto y-axis tick labels.
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (8)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4761.patch
https://github.com/bisq-network/bisq/pull/4761.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201107/54894e7e/attachment.html>
More information about the bisq-github
mailing list