[bisq-network/bisq] [WIP] Don't allow trade start if BitcoinJ is not fully synced (#4764)
James Cox
notifications at github.com
Sun Nov 8 06:31:49 CET 2020
Adds a check that chain height is within 3 blocks of the reported height from bitcoin peers -> if not the user is prevented from taking or creating an offer. It shows a message informing the user that Bisq is not currently synced, advising them to wait for one Bitcoin block.
Additionally under Settings/Network a field has been added to show the chain height of Bisq vs the Peer group. It can be
observed that Bisq chain height (from BitcoinJ) stays at 0 on startup until one new block has been published.
Fixes: #4727
Fixes: #4707
### Screenshots
![Screenshot from 2020-11-07 22-59-29](https://user-images.githubusercontent.com/47253594/98457742-13e7f100-2150-11eb-9c12-b48aa9cbdfd8.png)
Network info showing chain height:
![Screenshot from 2020-11-07 22-39-37](https://user-images.githubusercontent.com/47253594/98457746-2bbf7500-2150-11eb-8a80-7a910709f112.png)
Logged upon attempting to take or create offer when not synced:
![image](https://user-images.githubusercontent.com/47253594/98457800-67f2d580-2150-11eb-870f-d22c795a43c6.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4764
-- Commit Summary --
* Don't allow trade start if BitcoinJ is not fully synced
-- File Changes --
M core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (9)
M core/src/main/resources/i18n/displayStrings.properties (4)
M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (6)
M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.fxml (5)
M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (8)
M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (5)
M desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java (22)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4764.patch
https://github.com/bisq-network/bisq/pull/4764.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201107/97ad7e4e/attachment.html>
More information about the bisq-github
mailing list