[bisq-network/bisq] [REGTEST] Exception in BSQ wallet transactions view (#4775)
Oscar Guindzberg
notifications at github.com
Tue Nov 10 08:01:31 CET 2020
I could reproduce the bug.
I reproduced it on the v1.5.0 release branch
In fact, it is simpler to reproduce:
- Setup: Have 2 users: Alice, Bob. Alice has funds in BTC and BSQ wallets. Bob may or may not have funds
- Start Bisq (Alice, Bob)
- Alice sends all its BSQ to Bob. Generate a block.
- Look at Bob's BSQ transaction view. Crash as described in OP.
The reason is BsqTxListItem has a twisted way to find out the send/receive address.
The introduction of Segwit and forcing BSQ to use LegacyAddress exposed the problem.
I wrote a hack that solves the problem. It is not meant to be merged but to illustrate the problem:
https://github.com/oscarguindzberg/bisq/commit/6b720a4244e3fd8dbeff8d1b91cff159ceb5f97d
The ideal solution would be to rewrite the code in the BsqTxListItem constructor where it obtains the send/receive address.
There are a number of BSQ transaction types/cases to consider.
@chimp1984 could you look into this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4775#issuecomment-724505985
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201109/e8300e77/attachment.html>
More information about the bisq-github
mailing list