[bisq-network/bisq] Don't allow trade start if BitcoinJ is not fully synced (#4764)
chimp1984
notifications at github.com
Tue Nov 10 17:57:07 CET 2020
@chimp1984 approved this pull request.
utACK
> @@ -522,6 +523,16 @@ public boolean isDownloadComplete() {
return downloadPercentageProperty().get() == 1d;
}
+ public boolean isChainHeightSyncedToPeers() {
Maybe better rename it so it reflects that we have a tolernace for the check...
Maybe: `inSyncWithMostCommonChainHeight` ? (still not great but the "MostCommon" suggests we are not operating on exact data here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4764#pullrequestreview-527386803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201110/bc02ec8a/attachment.html>
More information about the bisq-github
mailing list