[bisq-network/bisq] Touch-ups to the DAO BSQ Supply page (#4785)

[deusmax]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
## Intro

The BSQ supply page on the DAO GUI tab, provides 3 charts and some numerical data (not statistics) on the BSQ supply.
For simplicity, I will refer here to the charts as chart#1 (top), chart#2 (middle) and chart#3 (bottom) to avoid any confusion with the names.
The charts and the page itself seems a little confusing. I decided to do some touch-ups to improve it. This is not a redesign of the page.

## Current Status 

The DAO BSQ pages, as of version 1.42 is like this:
![Bisq-Dao-Page-BSQ_Supply_top-2020-11-08](https://user-images.githubusercontent.com/142019/98921446-fb723080-24d9-11eb-9454-20d8057e55fe.png)
![Bisq-Dao-Page-BSQ_Supply_bottom-2020-11-08](https://user-images.githubusercontent.com/142019/98921479-075df280-24da-11eb-8af6-09415f6323c5.png)

## Results
The result of this PR is currently:
![Bisq-Dao-Page-BSQ_Supply_NEW_top-2020-11-12](https://user-images.githubusercontent.com/142019/98922113-c0bcc800-24da-11eb-8c2a-ff06e78acb77.png)
![Bisq-Dao-Page-BSQ_Supply_NEW_bottom-2020-11-12](https://user-images.githubusercontent.com/142019/98923219-0e860000-24dc-11eb-8420-7418eee13dc7.png)

## Description of changes

1. Chart touch-ups affect the display of lines and axes.
2. Removed Chart#2, it has no new information from Chart#1, so it is not needed.
3. Did not:
    - Check or touch any of the calculations in the number sections.
    - Removed chart#2 by commenting-out the relevant code and left as a placeholder. Easy to re-insert another chart in its place if/when needed.

### Remaining issues 

1. Chart#1 is a monthly summary, does not align well with the tick marks. Can be worked on.
2. Section **BSQ burnt** show a negative number for _Burned BSQ (fees)_. **Q:** Is that by design ?

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4785

-- Commit Summary --

  * Improve view of market offers chart
  * Touch ups on the DAO BSQ supply page.

-- File Changes --

    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (1)
    M desktop/src/main/java/bisq/desktop/bisq.css (14)
    M desktop/src/main/java/bisq/desktop/main/dao/economy/supply/SupplyView.java (91)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (50)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4785.patch
https://github.com/bisq-network/bisq/pull/4785.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201112/810141a3/attachment.html>