[bisq-network/bisq] Add proto fields to support trade fee currency choice (#4797)

Stan notifications at github.com
Fri Nov 13 16:06:52 CET 2020


This change adds proto support for paying maker fees in bsq or btc.  The implementation will come in a future PR.

- Added `makerFeeCurrencyCode` field to `CreateOfferRequest` proto.

- Added `isCurrencyForMakerFeeBtc` field to `OfferInfo` proto wrapper.

- Add `takerFeeCurrencyCode` field to `TakeOfferRequest` proto.


This is the 5th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4793.  

PR https://github.com/bisq-network/bisq/pull/4796 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4797

-- Commit Summary --

  * Define new grpc bsq/btc balances protos
  * Add proto wrappers for serving bsq, btc or all balances
  * Define proto for api method 'getunusedbsqaddress'
  * Define proto fapi method 'sendbsq'
  * Add proto fields to support trade fee currency choice

-- File Changes --

    A core/src/main/java/bisq/core/api/model/BalancesInfo.java (42)
    A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (87)
    A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (70)
    M proto/src/main/proto/grpc.proto (84)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4797.patch
https://github.com/bisq-network/bisq/pull/4797.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4797
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201113/fb9b7868/attachment.html>


More information about the bisq-github mailing list