[bisq-network/bisq] Implement and test api method 'getunusedbsqaddress' (#4798)
Stan
notifications at github.com
Fri Nov 13 16:48:10 CET 2020
- Added new method to CLI, split some long msg strings into two lines, and added a white space after a brace less else statement.
- Added the gRPC server boilerplate.
- Added the core implementation.
- Added a test, and moved method wallet tests into their own package.
- A second commit in the PR added a forgotten teardown for the test case.
This is the 6th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4793.
PR https://github.com/bisq-network/bisq/pull/4797 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4798
-- Commit Summary --
* Define new grpc bsq/btc balances protos
* Add proto wrappers for serving bsq, btc or all balances
* Define proto for api method 'getunusedbsqaddress'
* Define proto fapi method 'sendbsq'
* Add proto fields to support trade fee currency choice
* Implement and test api method 'getunusedbsqaddress'
* Add teardown to test case
-- File Changes --
M apitest/docs/build-run.md (2)
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (5)
A apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (64)
R apitest/src/test/java/bisq/apitest/method/wallet/GetBalanceTest.java (6)
R apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (6)
M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (2)
M cli/src/main/java/bisq/cli/CliMain.java (21)
M core/src/main/java/bisq/core/api/CoreApi.java (4)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (8)
A core/src/main/java/bisq/core/api/model/BalancesInfo.java (42)
A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (87)
A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (70)
M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (19)
M proto/src/main/proto/grpc.proto (84)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4798.patch
https://github.com/bisq-network/bisq/pull/4798.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4798
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201113/55640311/attachment.html>
More information about the bisq-github
mailing list