[bisq-network/bisq] Implement and test new getbalance(s) api methods (#4799)

Stan notifications at github.com
Fri Nov 13 18:26:45 CET 2020


- Added three new methods to CLI:
    
  `getbalances`     returns complete bsq and btc balance info
  `getbsqbalance` returns complete bsq balance info
  `getbtcbalance`  returns complete btc balance info
    
  The old getbalance method is deprecated and will be removed if there is agreement to do that.
    
- Made the needed changes in the CLI's output formatting classes.
    
- Added new tests to existing `BsqWalletTest`, added new `BtcWalletTest` and `WalletBalancesTest`.
    
- Added disabled test methods for funding a bsq wallet (todo in next PR).

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4799

-- Commit Summary --

  * Define new grpc bsq/btc balances protos
  * Add proto wrappers for serving bsq, btc or all balances
  * Define proto for api method 'getunusedbsqaddress'
  * Define proto fapi method 'sendbsq'
  * Add proto fields to support trade fee currency choice
  * Implement and test api method 'getunusedbsqaddress'
  * Add teardown to test case
  * Remove trailing spaces in blank line
  * Implement and test new getbalance(s) api methods

-- File Changes --

    M apitest/docs/build-run.md (2)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (68)
    A apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (246)
    A apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (102)
    R apitest/src/test/java/bisq/apitest/method/wallet/GetBalanceTest.java (7)
    A apitest/src/test/java/bisq/apitest/method/wallet/WalletBalancesTest.java (79)
    R apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (60)
    M cli/src/main/java/bisq/cli/CliMain.java (54)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (13)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (9)
    M cli/src/main/java/bisq/cli/TableFormat.java (76)
    M core/src/main/java/bisq/core/api/CoreApi.java (20)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (62)
    A core/src/main/java/bisq/core/api/model/BalancesInfo.java (42)
    A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (87)
    A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (70)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (83)
    M proto/src/main/proto/grpc.proto (84)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4799.patch
https://github.com/bisq-network/bisq/pull/4799.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201113/8f2a5d53/attachment.html>


More information about the bisq-github mailing list