[bisq-network/bisq] Stub out api method 'sendbsq' in core (#4800)

Stan notifications at github.com
Fri Nov 13 19:02:56 CET 2020


All the boilerplate for this method is included in this change, but the implementation in `CoreWalletsService#sendBsq` is commented out until the needed logic to send bsq is refactored out of desktop's `BsqSendView` class -- to be included in the next PR.
    
- Added new method to CLI.
    
- Added the `gRPC` server boilerplate.
    
- Added the core implementation, commented out.
    
- Left `sendbsq` tests commented out.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4800

-- Commit Summary --

  * Define new grpc bsq/btc balances protos
  * Add proto wrappers for serving bsq, btc or all balances
  * Define proto for api method 'getunusedbsqaddress'
  * Define proto fapi method 'sendbsq'
  * Add proto fields to support trade fee currency choice
  * Implement and test api method 'getunusedbsqaddress'
  * Add teardown to test case
  * Remove trailing spaces in blank line
  * Implement and test new getbalance(s) api methods
  * Resolve unnecessary use of fully qualified name for codacy
  * Stub out api method 'sendbsq' in core
  * Re comment sendbsq tests so travis ci does not fail

-- File Changes --

    M apitest/docs/build-run.md (2)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (68)
    A apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (244)
    A apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (102)
    R apitest/src/test/java/bisq/apitest/method/wallet/GetBalanceTest.java (7)
    A apitest/src/test/java/bisq/apitest/method/wallet/WalletBalancesTest.java (79)
    R apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (60)
    M cli/src/main/java/bisq/cli/CliMain.java (81)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (13)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (9)
    M cli/src/main/java/bisq/cli/TableFormat.java (76)
    M core/src/main/java/bisq/core/api/CoreApi.java (25)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (87)
    A core/src/main/java/bisq/core/api/model/BalancesInfo.java (42)
    A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (87)
    A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (70)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (121)
    M proto/src/main/proto/grpc.proto (84)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4800.patch
https://github.com/bisq-network/bisq/pull/4800.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4800
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201113/f9364b5b/attachment.html>


More information about the bisq-github mailing list