[bisq-network/bisq] Refactor desktop's BsqSendView 'sendbsq', share with api (#4801)

[Stan]

Moved just enough code out of `BsqSendView` to avoid desktop/api `sendbsq` duplication.

- Created new `BsqTransferModel` to hold tx details shared by desktop and api.

- Created new `BsqTransferService` to send bsq using a `BsqTransferModel` shared  by desktop and api.
  
- Uncommented `CoreWalletsService#sendBsq` implementation.

- Uncommented `sendbsq` tests.  


This is the 9th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4793.  

PR https://github.com/bisq-network/bisq/pull/4800 should be reviewed before this one.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4801

-- Commit Summary --

  * Define new grpc bsq/btc balances protos
  * Add proto wrappers for serving bsq, btc or all balances
  * Define proto for api method 'getunusedbsqaddress'
  * Define proto fapi method 'sendbsq'
  * Add proto fields to support trade fee currency choice
  * Implement and test api method 'getunusedbsqaddress'
  * Add teardown to test case
  * Remove trailing spaces in blank line
  * Implement and test new getbalance(s) api methods
  * Resolve unnecessary use of fully qualified name for codacy
  * Stub out api method 'sendbsq' in core
  * Re comment sendbsq tests so travis ci does not fail
  * Refactor desktop's BsqSendView, share with api

-- File Changes --

    M apitest/docs/build-run.md (2)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (68)
    A apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (244)
    A apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (102)
    R apitest/src/test/java/bisq/apitest/method/wallet/GetBalanceTest.java (7)
    A apitest/src/test/java/bisq/apitest/method/wallet/WalletBalancesTest.java (79)
    R apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (60)
    M cli/src/main/java/bisq/cli/CliMain.java (81)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (13)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (9)
    M cli/src/main/java/bisq/cli/TableFormat.java (76)
    M core/src/main/java/bisq/core/api/CoreApi.java (25)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (117)
    A core/src/main/java/bisq/core/api/model/BalancesInfo.java (42)
    A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (87)
    A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (70)
    A core/src/main/java/bisq/core/btc/model/BsqTransferModel.java (77)
    A core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (59)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (121)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (41)
    M proto/src/main/proto/grpc.proto (84)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4801.patch
https://github.com/bisq-network/bisq/pull/4801.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4801
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201113/c9f9486a/attachment.html>