[bisq-network/bisq] Various monitor improvements (#4787)

[Stan]

@ghubstan commented on this pull request.



> @@ -484,14 +487,12 @@ private String getErrorMsgLine(NodeAddress seedNode,
                 RequestInfo requestInfo1 = requestInfoList.get(i);
 
                 // We ignore old errors as at startup timeouts are expected and each node restarts once a day
-                if (requestInfo1.getRequestStartTime() > 0 &&
-                        System.currentTimeMillis() - requestInfo1.getRequestStartTime() > TimeUnit.HOURS.toMillis(24)) {

I almost left a comment regarding a little precedence confusion, re:

    ( System.currentTimeMillis() - requestInfo1.getRequestStartTime()  ) > TimeUnit.HOURS.toMillis(24)

The precedence rules work, but now it's clear from the change below.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4787#pullrequestreview-530826878
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201115/79af978e/attachment.html>