[bisq-network/bisq] Use AES key for signing when wallet is encrypted (#4820)
Oscar Guindzberg
notifications at github.com
Wed Nov 18 22:32:17 CET 2020
<!--
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
I forgot to pass the AES key as a parameter. Without this change, encrypted wallets can not sign transactions
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4820
-- Commit Summary --
* Calculate witness sig with AES key
-- File Changes --
M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (2)
M core/src/main/java/bisq/core/btc/wallet/WalletService.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4820.patch
https://github.com/bisq-network/bisq/pull/4820.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201118/15c3ff25/attachment.html>
More information about the bisq-github
mailing list