[bisq-network/bisq] Fix issues with missing persistence for trade state (#4816)

James Cox notifications at github.com
Thu Nov 19 00:59:30 CET 2020


@jmacxx requested changes on this pull request.



> @@ -65,6 +65,7 @@ public BuyerAsTakerProtocol(BuyerAsTakerTrade trade) {
 
         Offer offer = checkNotNull(trade.getOffer());
         processModel.getTradingPeer().setPubKeyRing(offer.getPubKeyRing());
+        processModel.getTradeManager().requestPersistence();

I'm getting a NPE here, processModel.tradeManager is null

> @@ -59,6 +59,7 @@ public SellerAsTakerProtocol(SellerAsTakerTrade trade) {
         super(trade);
         Offer offer = checkNotNull(trade.getOffer());
         processModel.getTradingPeer().setPubKeyRing(offer.getPubKeyRing());
+        processModel.getTradeManager().requestPersistence();

I get a NPE here, processModel.tradeManager is null.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4816#pullrequestreview-533977323
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201118/a7fafb21/attachment.html>


More information about the bisq-github mailing list