[bisq-network/bisq] Fix issues with missing persistence for trade state (#4816)

[chimp1984]

> I feel it might be cleaner to do the persist in the `complete()` method at the end of each trade task. It feels like that's what's being done with this PR anyway, but separately in each task with the chance of missing it somewhere.
> 
> Apart from that I think this looks ok and could be merged.

I was wondering myself if we should add at the tradeTask complete handler a perist call. It would add extra redundancy in case I missed one as well in case we add some tasks or have some changes and the call is forgotten. 
I have no strong opinion for or against it. Signal with up or downvote if you want to have it in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4816#issuecomment-730060112
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201118/f20854b7/attachment.html>