[bisq-network/bisq] Fix issues with missing persistence for trade state (#4816)
chimp1984
notifications at github.com
Thu Nov 19 17:00:07 CET 2020
> With the persistence call in complete() it's not necessary to persist in each trade task.
A reason why I did not do want to rely only on complete is as there are async tasks and i want to be sure that if the task never completes (shutdown) that the intermediate state change is persisted. But also not happy that its that verbose now ;-(. But its more similar as it was before, just that some calls have been done inside the trade setter methods.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4816#issuecomment-730470802
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201119/78ada5ad/attachment.html>
More information about the bisq-github
mailing list