[bisq-network/bisq] Check if user has downgraded to an older version (#4829)

[chimp1984]

Check if user has downgraded to an older version. If so require shutdown 
and do not read or write persisted data.

We had recently a case where a user downgraded from 1.4.2 to 1.3.9 and
this caused failed trades and the wallet funds have been missing due to
some complexities of the wallet wegwit upgrade. The fund could be recovered
but it took quite some effort.
As downgrade is never tested and can lead to all kind of weird bugs we
should prevent that users accidentally can do it.
If there is valid reason to downgrade they can remove the version file.

I would suggest that we add that to 1.5.0 as it is a critical update which would likely cause major issues if users downgrade. But up to maintainers if they consider risk/benefit ration in favor to add it to the release.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4829

-- Commit Summary --

  * Avoid nullpointer
  * Check if user has downgraded to an older version. If so require shutdown

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (53)
    M core/src/main/java/bisq/core/app/BisqHeadlessApp.java (3)
    M core/src/main/java/bisq/core/app/BisqSetup.java (79)
    M core/src/main/resources/i18n/displayStrings.properties (1)
    M desktop/src/main/java/bisq/desktop/main/MainView.java (2)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4829.patch
https://github.com/bisq-network/bisq/pull/4829.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4829
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201120/f499efd8/attachment.html>