[bisq-network/bisq] Set country on MoneyGram acct in gson type adapter (#4834)
Stan
notifications at github.com
Sat Nov 21 19:32:45 CET 2020
- Added is `instanceof MoneyGramAccount` method to abstract `PaymentAccount`.
- Refactored `PaymentAccountTypeAdapter` to fix problem setting country on a `MoneyGramAccount`.
- Enabled create `MoneyGramAccount` api test.
This is the 18th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4793.
PR https://github.com/bisq-network/bisq/pull/4828 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4834
-- Commit Summary --
* Define new grpc bsq/btc balances protos
* Add proto wrappers for serving bsq, btc or all balances
* Define proto for api method 'getunusedbsqaddress'
* Define proto fapi method 'sendbsq'
* Add proto fields to support trade fee currency choice
* Implement and test api method 'getunusedbsqaddress'
* Add teardown to test case
* Remove trailing spaces in blank line
* Implement and test new getbalance(s) api methods
* Resolve unnecessary use of fully qualified name for codacy
* Stub out api method 'sendbsq' in core
* Re comment sendbsq tests so travis ci does not fail
* Refactor desktop's BsqSendView, share with api
* Resolve 'Avoid creating BigDecimal with a decimal' issue for codacy
* Support paying trade fees in bsq or btc (api)
* Delete deprecated api test, adjust api build/run doc
* Refactor api getbalance methods.
* Fix typo
* Remove unnecessary fully qualified name
* Remove unused imports
* Add api method 'getpaymentmethods'
* Avoid codacy issue over use of fully qualified name
* Revert "Avoid codacy issue over use of fully qualified name"
* Print the payment method id (only)
* Avoid codacy issue over use of fully qualified name
* Make codacy happy again
* Add ReflectionUtils to common.util pkg
* Add new (gson) PaymentAccountTypeAdapter to core.api.model
* Add isCountryBasedPaymentAccount to abstract PaymentAccount
* Add new PaymentAccountForm to core.api.model
* Add boilerplate for new 'getpaymentacctform' api method
* Add new api method 'getpaymentacctform' to CLI
* Test new api method 'getpaymentacctform'
* Ensure EXPECTED_FORM.clear() is never skipped
* Replace existing api method 'createpaymentacct' impl
* Avoid 'unnecessary use of fully qualified name' codacy issue
* Tidy up payment accts api related msgs on CLI
* Fix createpaymentacct validation problems
* Log server stack traces, pass concise err msgs to CLI
* Add create payment account (api) tests
* Reverse argument order for assert(expected, actual) convention
* Add isMoneyGramAccount to abstract PaymentAccount
* Refactor didReadCountryField to set country on MoneyGram acct
* Enable CreateMoneyGramAccount test
-- File Changes --
M apitest/docs/build-run.md (2)
D apitest/src/test/java/bisq/apitest/method/CreatePaymentAccountTest.java (99)
D apitest/src/test/java/bisq/apitest/method/GetBalanceTest.java (73)
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (134)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (24)
M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (1)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (11)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (14)
M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (1)
A apitest/src/test/java/bisq/apitest/method/payment/AbstractPaymentAccountTest.java (196)
A apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java (839)
A apitest/src/test/java/bisq/apitest/method/payment/GetPaymentMethodsTest.java (53)
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (20)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (18)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (18)
A apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (244)
A apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (107)
R apitest/src/test/java/bisq/apitest/method/wallet/WalletProtectionTest.java (22)
D apitest/src/test/java/bisq/apitest/scenario/FundWalletScenarioTest.java (76)
A apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java (90)
M apitest/src/test/java/bisq/apitest/scenario/StartupTest.java (8)
M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (50)
M cli/src/main/java/bisq/cli/CliMain.java (185)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (13)
M cli/src/main/java/bisq/cli/CurrencyFormat.java (9)
M cli/src/main/java/bisq/cli/TableFormat.java (76)
A common/src/main/java/bisq/common/util/ReflectionUtils.java (108)
M core/src/main/java/bisq/core/api/CoreApi.java (37)
M core/src/main/java/bisq/core/api/CoreOffersService.java (8)
M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (110)
M core/src/main/java/bisq/core/api/CoreTradesService.java (8)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (133)
A core/src/main/java/bisq/core/api/model/BalancesInfo.java (45)
A core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (94)
A core/src/main/java/bisq/core/api/model/BtcBalanceInfo.java (75)
M core/src/main/java/bisq/core/api/model/OfferInfo.java (10)
A core/src/main/java/bisq/core/api/model/PaymentAccountForm.java (242)
A core/src/main/java/bisq/core/api/model/PaymentAccountTypeAdapter.java (347)
A core/src/main/java/bisq/core/btc/model/BsqTransferModel.java (77)
A core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (59)
M core/src/main/java/bisq/core/offer/OfferUtil.java (18)
M core/src/main/java/bisq/core/payment/PaymentAccount.java (8)
M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (1)
M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (97)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (1)
M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (75)
M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (41)
M proto/src/main/proto/grpc.proto (95)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4834.patch
https://github.com/bisq-network/bisq/pull/4834.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4834
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201121/44e740e1/attachment.html>
More information about the bisq-github
mailing list