[bisq-network/compensation] [WIP] For Cycle 19 (#716)

[Stan]

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`[BSQ amount]`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: [USD amount] <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 0.67 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #688  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Block on tx-fee-request in core TakeOfferModel init | dev | --- | https://github.com/bisq-network/bisq/pull/4692 | merged |
| Add fields to grpc TradeInfo proto & wrapper | dev | --- | https://github.com/bisq-network/bisq/pull/4696 | merged |
| Replace TradeUtils with singleton TradeUtil | dev | --- | https://github.com/bisq-network/bisq/pull/4697 | merged |
| Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil | dev | --- | https://github.com/bisq-network/bisq/pull/4699 | merged |
| Refactor PendingTradesDataModel methods -> TradeUtil | dev | --- | https://github.com/bisq-network/bisq/pull/4700 | merged |
| Add getRole(tradeId) to core api | dev | --- | https://github.com/bisq-network/bisq/pull/4701 | merged |
| Refactor CLI output formatting code & add trade formatter | dev | --- | https://github.com/bisq-network/bisq/pull/4703 | merged |
| Add 'gettrade' to api method CLI | dev | --- | https://github.com/bisq-network/bisq/pull/4704 | merged |
| Add boolean 'showcontract' argument to api's 'gettrade' | dev | --- | https://github.com/bisq-network/bisq/pull/4705 | merged |
| Stub out api methods 'keepfunds', 'withdrawfunds' | dev | --- | https://github.com/bisq-network/bisq/pull/4709 | merged |
| Implement api methods 'keepfunds', 'withdrawfunds' | dev | --- | https://github.com/bisq-network/bisq/pull/4711 | merged |
| Test trade closing api methods 'keepfunds', 'withdrawfunds' | dev | --- | https://github.com/bisq-network/bisq/pull/4712 | merged |
| Stub out 'canceloffer' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4713 | merged |
| Implement 'canceloffer' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4714 | merged |
| Test 'canceloffer' api method | dev | --- | https://github.com/bisq-network/bisq/pull/4716 | merged |
| Upgrade jupiterVersion = '5.7.0' | dev | --- | https://github.com/bisq-network/bisq/pull/4722 | merged |
| Improve apitest cmd line console logging | dev | --- | https://github.com/bisq-network/bisq/pull/4723 | merged |
| Refactor api test fixture setup | dev | --- | https://github.com/bisq-network/bisq/pull/4724 | merged |
| Reduce apitest suite execution time | dev | --- | https://github.com/bisq-network/bisq/pull/4725 | merged |
| Reduce apitest suite execution time | dev | --- | https://github.com/bisq-network/bisq/pull/4725 | merged |
| Resolve issues found in reviewed PRs 4699, 4703, 4711 | dev | --- | https://github.com/bisq-network/bisq/pull/4731 | merged |
| PR review | dev | --- | https://github.com/bisq-network/bisq/pull/4702 | merged |
| PR review | dev | --- | https://github.com/bisq-network/bisq/pull/4706 | merged |
| PR review | dev | --- | https://github.com/bisq-network/bisq/pull/4715 | merged |
| PR review | dev | --- | https://github.com/bisq-network/bisq/pull/4787 | merged |
| PR review | dev | --- | https://github.com/bisq-network/bisq/pull/4829 | merged |
<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Define new grpc bsq/btc balances protos | dev | --- | https://github.com/bisq-network/bisq/pull/4793 | awaiting review |
| Add proto wrappers for sending bsq, btc or all balances | dev | --- | https://github.com/bisq-network/bisq/pull/4794 | awaiting review |
| Define proto for api method 'getunusedbsqaddress' | dev | --- | https://github.com/bisq-network/bisq/pull/4795 | awaiting review |
| Define proto for api method 'sendbsq' | dev | --- | https://github.com/bisq-network/bisq/pull/4796 | awaiting review |
| Add proto fields to support trade fee currency choice | dev | --- | https://github.com/bisq-network/bisq/pull/4797 | awaiting review |
| Implement and test api method 'getunusedbsqaddress' | dev | --- | https://github.com/bisq-network/bisq/pull/4798 | awaiting review |
| Implement and test new getbalance(s) api methods | dev | --- | https://github.com/bisq-network/bisq/pull/4799 | awaiting review |
| Stub out api method 'sendbsq' in core | dev | --- | https://github.com/bisq-network/bisq/pull/4800 | awaiting review |
| Refactor desktop's BsqSendView 'sendbsq', share with api | dev | --- | https://github.com/bisq-network/bisq/pull/4801 | awaiting review |
| Support paying trade fees in bsq or btc in api | dev | --- | https://github.com/bisq-network/bisq/pull/4802 | awaiting review |
| Delete deprecated api wallet test, adjust api build/run doc | dev | --- | https://github.com/bisq-network/bisq/pull/4803 | awaiting review |
| Refactor getbalance api | dev | --- | https://github.com/bisq-network/bisq/pull/4808 | awaiting review |
| Add api method 'getpaymentmethods' | dev | --- | https://github.com/bisq-network/bisq/pull/4818 | awaiting review |
| Add api method 'getpaymentacctform'  | dev | --- | https://github.com/bisq-network/bisq/pull/4819 | awaiting review |
| Replace existing api method 'createpaymentacct' impl | dev | --- | https://github.com/bisq-network/bisq/pull/4821 | awaiting review |
| Fix api's createpaymentacct validation problems | dev | --- | https://github.com/bisq-network/bisq/pull/4824 | awaiting review |
| Add more 'createpaymentacct' api tests | dev | --- | https://github.com/bisq-network/bisq/pull/4828 | awaiting review |
| Set country on MoneyGram acct in gson type adapter | dev | --- | https://github.com/bisq-network/bisq/pull/4834 | awaiting review |
| Update bats api test | dev | --- | https://github.com/bisq-network/bisq/pull/4836 | awaiting review |



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/716
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201124/d27fc62e/attachment-0001.html>