[bisq-network/bisq] Implement and test new getbalance(s) api methods (#4799)

[sqrrm]

@sqrrm commented on this pull request.

utACK

Will merge after 1.5.0 is merged to master

> @@ -104,12 +113,25 @@ public static void startSupportingApps(boolean registerDisputeAgents,
 
     // Convenience methods for building gRPC request objects
 
+    @Deprecated
     protected final GetBalanceRequest createBalanceRequest() {

Let's remove this. As the API hasn't been officially released we can just remove it unceremoniously.

> +
+        verifyBsqBalances(expectedBsqBalanceModel(97499950,
+                97499950,
+                97499950,
+                0,
+                0,
+                0),
+                alicesBsqBalances);
+    }
+
+    @Disabled // TODO
+    @Test
+    @Order(4)
+    public void testBalancesAfterSendingBsqAndGeneratingBtcBlock(final TestInfo testInfo) {
+        // There is a wallet persist delay;  we have to
+        // wait for both wallets to be saved to disk.

Persistence has had some changes to increase the persist frequency, might not need to wait this long

> @@ -88,7 +92,10 @@
         createpaymentacct,
         getpaymentaccts,
         getversion,
-        getbalance,
+        @Deprecated getbalance, // Use getbalances, return bsq and btc balance info

Let's remove it

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4799#pullrequestreview-538413255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201125/4bc1e075/attachment.html>