[bisq-network/bisq] Account management usability improvements (#4863)
James Cox
notifications at github.com
Fri Nov 27 21:38:07 CET 2020
Implements some requests from #4837 :
- Widen payment account dropdown in create & edit offer screens
- Sort payment account dropdown by name in create & edit offer screens
- Sort account listview by name in manage fiat accounts screen
- Sort account listview by name in manage altcoin accounts screen
- Bug fix: do not adjust BTC amount in edit offer screen
There was a bug where editing an existing offer could have its payment account changed to one with more restrictive limits and the offer would still be allowed (although not take-able). It should not be allowed to be saved in this case. This change takes proper heed of the `allowAmountUpdate` flag which is false for offer edits.
e.g. edit an F2F buy for 0.25, change to Zelle unsigned, the offer will prevent saving.
Ref: https://github.com/bisq-network/bisq/issues/4837#issuecomment-734647423
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4863
-- Commit Summary --
* Account management usability improvements
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java (3)
M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java (2)
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (4)
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (9)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4863.patch
https://github.com/bisq-network/bisq/pull/4863.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4863
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201127/ed8c4bcf/attachment.htm>
More information about the bisq-github
mailing list