[bisq-network/bisq] Upgrade JavaFX to v15 (#4242)

Christoph Atteneder notifications at github.com
Thu Oct 1 08:26:56 UTC 2020


Building the binary on macOS works fro me know again. I did build the client and did some quick smoke testing and besides the misalignment I mentioned before nothing else popped up on my side. I'll have a look as this styling issue now.

I think a good next step would be to try to get the macOS bundle and release process as close as possible to the original one.
Atm the created dmg (no need for the pkg bundle) looks like this.
![Bildschirmfoto 2020-10-01 um 10 09 46](https://user-images.githubusercontent.com/170962/94784399-62c29e00-03ce-11eb-97a1-8e399d803df7.png)
But @pedromvpg 's design for it is
![Bildschirmfoto 2020-10-01 um 10 10 40](https://user-images.githubusercontent.com/170962/94784435-6e15c980-03ce-11eb-9c8a-d8ddf9116bf0.png)
e.g. in the old javapackager I was able to customize this by modifying a setup script found here https://github.com/bisq-network/bisq/blob/master/desktop/package/macosx/Bisq-dmg-setup.scpt 

I quickly checked [Resources Used in Packaging](https://docs.oracle.com/en/java/javase/14/jpackage/packaging-tool-user-guide.pdf) and saw that everything we used in the past is still supported. So the effort is to point the resources directory to the right place.

Could you please adapt the macOS build so that it matches what we had in the past?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#issuecomment-701976881
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201001/ed6885ae/attachment.html>


More information about the bisq-github mailing list