[bisq-network/bisq] Add api convenience 'getoffer offer-id' method (#4584)

Stan notifications at github.com
Thu Oct 1 16:29:10 UTC 2020


An API convenience for getting a current offer with an offer id.  Also stubbed out a `takeoffer` proto def.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4584

-- Commit Summary --

  * Add options helper for handling negative number CLI params
  * Add license comment
  * Add license comment and btc-string to satoshi converter
  * Print createoffer's reply in the CLI's console
  * Add comment to empty catch block for codacy
  * Uppercase direction & ccy-code CLI arguments in core
  * Change 'createoffer' argument order
  * Scale & convert (double) fixed price input to long
  * Move 'createoffer' price arg transform to server & test it
  * Push currencyCode.toUpperCase conversion below CoreApi
  * Convert mktPriceMargin to %, make createAndPlaceOffer private
  * Minor createoffer test changes
  * Do not reassign currencyCode parameter
  * Delete trailing spaces from blank line for codacy
  * Add simple mkt-price service & test calculated offer prices
  * Fix abs(dbl) comparison
  * Remove unused import
  * Add license comment
  * Tidy up create offer using mkt price margin % test
  * Redefine DisputeAgentType REFUNDAGENT as REFUND_AGENT
  * Fix asserts
  * Factor out duplicated OfferInfo wrapping
  * Fix 'switch statements should have a default label' codacy problem
  * Revert "Fix 'switch statements should have a default label' codacy problem"
  * Codacy requires default label in switch
  * Fix tx result handling in GrpcOffersService
  * Fix BitcoinCli wrapper create bug
  * Throw exception to CLI if attempted offer placement fails
  * Make task handler's error msg CLI friendly (needs review)
  * Check for null
  * Create 'placeoffer' method
  * Reduce verbosity of task error msg passed to CLI
  * Add api convenience 'getoffer offer-id' method
  * Fix comment
  * Fix comment, remove deprecated tag

-- File Changes --

    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (1)
    D apitest/src/test/java/bisq/apitest/method/CreateOfferTest.java (112)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (37)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (6)
    A apitest/src/test/java/bisq/apitest/method/offer/AbstractCreateOfferTest.java (125)
    A apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (174)
    A apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (307)
    A apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (63)
    M cli/src/main/java/bisq/cli/CliMain.java (130)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (30)
    M cli/src/main/java/bisq/cli/GrpcStubs.java (3)
    A cli/src/main/java/bisq/cli/NegativeNumberOptions.java (81)
    M cli/src/main/java/bisq/cli/TableFormat.java (21)
    M common/src/main/java/bisq/common/taskrunner/Task.java (3)
    M common/src/main/java/bisq/common/taskrunner/TaskRunner.java (11)
    M core/src/main/java/bisq/core/api/CoreApi.java (50)
    M core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java (57)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (184)
    A core/src/main/java/bisq/core/api/CorePriceService.java (55)
    M core/src/main/java/bisq/core/support/dispute/agent/DisputeAgent.java (8)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (126)
    A daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java (58)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (7)
    M proto/src/main/proto/grpc.proto (49)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4584.patch
https://github.com/bisq-network/bisq/pull/4584.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4584
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201001/272534d8/attachment.html>


More information about the bisq-github mailing list