[bisq-network/bisq] Reduce initial date request (#4586)

chimp1984 notifications at github.com
Thu Oct 1 20:27:00 UTC 2020


This is a clean version of https://github.com/bisq-network/bisq/pull/4519 which was based on #4233 from @freimair.
I decided to remove the git commit history and make new clean commits as it was too messy before and not easy to review.

Now the commits are clearly separated between pure refactoring, small not complex changes and the feature implementation.
It is basically only 2 commits which carry the main feature implementation. I hope that makes it easier to review and to get it merged.

In the last commit I deactivated the usage if the feature as we should deply it together with https://github.com/bisq-network/bisq/pull/4577 which is not ready yet and which will require some deployment planning and coordination. By revderting that last commit the feature gets activated.

By having the code base merged but not activated we avoid that the code base gets into problems with other large code change PRs which are pending but avoid any serious risk as it is a not executed code path.
Also we gain the benefit to have the version support deployed in case we decide to release the actiavted version in a later release.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4586

-- Commit Summary --

  * Add PersistableNetworkPayloadStore
  * Use PersistableNetworkPayloadStore as base class for stores which had a map with PersistableNetworkPayloads
  * Unrelated to PR topic fix: Only log warnings if banned object is not isEmpty
  * Unrelated to PR topic: Improve logs for windows: \n is not recognized and reading logs from windows users makes it harder without line breaks.
  * Refactoring: Rename variables
  * Add new methods and refactor APIs. Needed later for new classes....
  * Split read store and get store so it can be reused from new class (future commit)
  * Add version field to data requests classes
  * Add getter (needed later)
  * Add HistoricalDataStoreService
  * Add HISTORY field. Make isNewVersion public
  * Refactoring: Rename variable
  * Add support for HistoricalDataStoreService
  * Refactoring: Rearrange method (moved method)
  * Use HistoricalDataStoreService for TradeStatistics2StorageService
  * Apply changes to test classes
  * Deactivate usage of HistoricalDataStoreService for now.

-- File Changes --

    M common/src/main/java/bisq/common/app/Version.java (10)
    M common/src/main/java/bisq/common/storage/Storage.java (11)
    M core/src/main/java/bisq/core/account/sign/SignedWitnessStore.java (11)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessStore.java (11)
    M core/src/main/java/bisq/core/dao/governance/blindvote/storage/BlindVoteStore.java (11)
    M core/src/main/java/bisq/core/dao/governance/proposal/storage/appendonly/ProposalStore.java (11)
    M core/src/main/java/bisq/core/provider/ProvidersRepository.java (5)
    M core/src/main/java/bisq/core/support/dispute/agent/DisputeAgentService.java (5)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2StorageService.java (12)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2Store.java (11)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java (5)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java (12)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java (9)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/messages/GetDataRequest.java (11)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/messages/GetUpdatedDataRequest.java (24)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/messages/PreliminaryGetDataRequest.java (34)
    M p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java (153)
    M p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java (4)
    A p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java (187)
    A p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadStore.java (20)
    M p2p/src/main/java/bisq/network/p2p/storage/persistence/StoreService.java (26)
    M p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageBuildGetDataResponseTest.java (13)
    M p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageRequestDataTest.java (8)
    M p2p/src/test/java/bisq/network/p2p/storage/mocks/AppendOnlyDataStoreServiceFake.java (8)
    M proto/src/main/proto/pb.proto (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4586.patch
https://github.com/bisq-network/bisq/pull/4586.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4586
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201001/1fd03cd5/attachment-0001.html>


More information about the bisq-github mailing list