[bisq-network/bisq] Build out 'createoffer' API method (#4559)

[sqrrm]

@sqrrm commented on this pull request.



> +                default:
+                    // Codacy requires default label in switch, Intellij does not.
+                    //noinspection UnnecessaryReturnStatement
+                    return;

I think we can ignore codacy on this one going forward as it's possible to merge even when it's complaining. Perhaps we could even configure codacy to ignore it.

> @@ -65,7 +67,7 @@ protected void failed(String message) {
 
     protected void failed(Throwable t) {
         log.error(errorMessage, t);
-        taskHandler.handleErrorMessage(errorMessage);
+        taskHandler.handleErrorMessage(format("%s: %s", errorMessage, t.getMessage()));

The UI might get a bit verbose on errors with this change.

> +                    if (nonOptionArgs.size() < 9)
+                        throw new IllegalArgumentException("incorrect parameter count,"
+                                + " expecting buy | sell, payment acct id, currency code, amount, min amount,"
+                                + " use-market-based-price, fixed-price | mkt-price-margin, security-deposit");

I think this was fixed in a later commit

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-501060470
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201002/8fc7c942/attachment.html>