[bisq-network/bisq] Reduce initial data request (#4586)

chimp1984 notifications at github.com
Fri Oct 2 18:19:34 UTC 2020


@chimp1984 commented on this pull request.



> +        if (anyMapContainsKey(hash)) {
+            return null;
+        }
+
+        PersistableNetworkPayload previous = getMapOfLiveData().put(hash, payload);

Yes it will be always null, but we override the method signature from MapStoreService and follow the putIfAbsent signature from Map. In our special case it wil be always null. I can change it to make it more clear and add a comment. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4586#discussion_r498979809
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201002/405c9947/attachment-0001.html>


More information about the bisq-github mailing list